-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SY-1093 Additional Schematic Symbols, SY-975 Fix Nested Button Element in Schematic #830
base: rc
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## rc #830 +/- ##
==========================================
- Coverage 46.32% 45.74% -0.59%
==========================================
Files 1089 1090 +1
Lines 68058 69044 +986
Branches 3503 3508 +5
==========================================
+ Hits 31531 31584 +53
- Misses 35482 36416 +934
+ Partials 1045 1044 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…om/synnaxlabs/synnax into sy-1093-additional-schematic-symbols
…om/synnaxlabs/synnax into sy-1093-additional-schematic-symbols
…3-additional-schematic-symbols
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can make some of these a different PR, but major thoughts:
- The "Label Alignment" feature moves the element around and not the label when the label is bigger than the element. This causes issues such as the handles for edges not matching up with the right point on the element.
- The "text alignment" feature should have an option for justified as well.
- Off Page Reference:
- Should not have the label wrap width, label alignment, or second set of orientation controls.
- Value:
- Something is a little off with the value width. Sometimes, I update it and the value box does not re-render.
- The orientation does not seem to do anything, it should change the label orientation.
- Also should be able to change the orientation of the actual value
- Should be able to change the text size of the actual value and units
- Switch:
- Orientation controls act very odd. They move the control chip around but not the actual orientation of the switch.
- Button:
- Orientation controls act very odd, they move the control chip around but not the button.
- Don't need the label wrap width or label alignment.
- Should be able to toggle if the control chip is visible
- Setpoint:
- When the units get too large, they overflow oddly.
- I still think it should function more like a button (you only have a command channel, its display does not change based off of the response) and less like the switch.
- When I change the color, the boxes don't change synchronously, which is super trippy.
- Text Box:
- Add left / center / right / alignment.
- Be able to make the text change orientation
- Tank / Box:
- Box border radius should have "px" at the end
- The orientation guide does not work
- Move scale to percent based, and add a percentage at the end in the forms.
- I still got these errors in my console:
- "Warning: Received
true
for a non-boolean attributevisible
." - "Warning: Received
false
for a non-boolean attributefocused
." - "Warning: React does not recognize the
aetherKey
prop on a DOM element." - "Warning: React does not recognize the
endIcon
prop on a DOM element."
- "Warning: Received
drift/src/sync.ts
Outdated
@@ -110,6 +110,7 @@ export const syncCurrent = async ( | |||
// so we move the window a smidge to emit events in order to do things like | |||
// hide traffic lights | |||
runtime.setPosition(xy.translate(position as xy.XY, { x: 1, y: 1 })); | |||
runtime.setPosition(position as xy.XY); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was this line added?
|
||
// import "@synnaxlabs/pluto/dist/style.css"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be uncommented.
Feature Pull Request Template
Key Information
Description
<button>
would render as a descendent of another<button>
in the Console DOM.Basic Readiness Checklist
Migrations
properly migrated to new formats.
properly migrated to new formats.
Additional Notes
Manual QA Additions
with necessary manual QA steps to test my change.
Breaking Changes
Please list any breaking changes to public or internal packages.
Reviwer Checklist